search

chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1923: i18n - Intermittent unit test failures - I18n.bundle NPE #1813

Closed chenejac closed 3 years ago

chenejac commented 3 years ago

Andrew Woods (Migrated from VIVO-1923) said:

This bug occurs intermittently when building VIVO due to the I18nStub bundle not being "setup". This was fixed for one unit test class: https://github.com/vivo-project/Vitro/commit/80140a8ab0c82334a16d42708a4f22f0e2afc323#diff-064ab49fc0040c4f39a58244e845ad1fR32-R36

In order to minimize repeated code, a JUnit TestExecutionListener may be helpful: https://junit.org/junit5/docs/current/user-guide/#launcher-api-listeners-custom

chenejac commented 3 years ago

Andrew Woods said:

Pull-request: https://github.com/vivo-project/Vitro/pull/186

chenejac commented 3 years ago

William Welling said:

Additional pull-request: [https://github.com/vivo-project/Vitro/pull/187]

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/Vitro/commit/2442d6dba52282f15395992b7f9578d1cdc92c73 and https://github.com/vivo-project/Vitro/commit/098cf0918bd819e0a58425ec8b8c223074164d6a