search

chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1930: Update example.runtime.properties #1820

Closed chenejac closed 3 years ago

chenejac commented 3 years ago

Benjamin Gross (Migrated from VIVO-1930) said:

The example.runtime.properties file includes some confusing things

The Solr configuration and description is out of date https://github.com/vivo-project/VIVO/blob/master/home/src/main/resources/config/example.runtime.properties#L80

Email parameters are included by default, but there's no best practice in the VIVO documentation for setting this up, so it throws a warning on VIVO startup. https://github.com/vivo-project/VIVO/blob/master/home/src/main/resources/config/example.runtime.properties#L72

ORCID api version 1.2 no longer exists https://github.com/vivo-project/VIVO/blob/master/home/src/main/resources/config/example.runtime.properties#L231

chenejac commented 3 years ago

Benjamin Gross said:

Additional notes... Vitro's version of example.runtime.properties has diverged from VIVO's.

chenejac commented 3 years ago

Benjamin Gross said:

Pull requests: https://github.com/vivo-project/VIVO/pull/194 https://github.com/vivo-project/Vitro/pull/190

chenejac commented 3 years ago

Andrew Woods said:

Pending response to code review.

chenejac commented 3 years ago

Benjamin Gross said:

[~accountid:60785ded115da6006f540529] 

Since example.runtime.properties is being touched in the i18n sprint, we likely won't be able to merge https://github.com/vivo-project/VIVO/pull/194/files and https://github.com/vivo-project/Vitro/pull/190/files without raising merge conflicts. If I redo the PRs and base them off sprint-i18 can we move them forward?

chenejac commented 3 years ago

Andrew Woods said:

Sure, that works.

Although, are the changes in main and those in sprint-i18n actually touching any of the same lines? Is there actually even going to be a merge-conflict... and even if there is, it should be pretty clear.

But that said, feel free to address the concern now... and let me know when this ticket is once again ready for review/merge.

chenejac commented 3 years ago

Andrew Woods said:

Updated PR: https://github.com/vivo-project/VIVO/pull/222

chenejac commented 3 years ago

Brian Lowe said:

Resolved in commit: https://github.com/vivo-project/VIVO/commit/5f6cabc42af652bb09afc0eed0fa85da40548e30