search

chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1934: i18n: Limit i18n .ftl files to minimal set #1824

Closed chenejac closed 3 years ago

chenejac commented 3 years ago

Andrew Woods (Migrated from VIVO-1934) said:

This task is to identify the minimal set of '.ftl' files that are needed in the various i18n translations, and remove the others. Ideally, i18n properties would be sufficient for language-specific customization in most cases.

chenejac commented 3 years ago

Andrew Woods said:

All languages (en_US, en_CA, pt_BR, es, de_DE) share the same set of files (except fr_CA):

[~accountid:5d7a3f78458a170db4b08b25], after reviewing all of the .ftl files in VIVO-languages and Vitro-languages, I have compiled a list of recommendations found in the two attached files:

I would like to move forward with the recommended changes if you agree.

chenejac commented 3 years ago

Michel Héon said:

[~accountid:60785ded115da6006f540529] In first estimation, the files identified by:

** Only single/double quote differences, remove from fr_CA"

Can be suppressed if the management of quotes is corrected, i.e. javascript is able to manage variables containing single-quote in a value.

For the others, there are specificities in fr_CA. You have to pass the files one by one... but here again as a first approximation I would leave these files in place and let the identification of problems by beta testing

chenejac commented 3 years ago

Andrew Woods said:

Pull-requests:

chenejac commented 3 years ago

Benjamin Gross said:

https://github.com/vivo-project/VIVO-languages/commit/b0ef29db5142cfb90f7dd4223608d349da27b545 https://github.com/vivo-project/Vitro-languages/commit/ba93dab2a65b77363def07551f9aed08bf677b73