chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1947: i18n: Editing labels deletes all other labels in certain cases #1836

Closed chenejac closed 3 years ago

chenejac commented 3 years ago

Benjamin Gross (Migrated from VIVO-1947) said:

In some situations, editing a label seems to work by:

  1. Delete all existing labels, regardless of language context
  2. Add 'edited' label in current language context

This isn't good!

+Triple situation prior to editing+ Using query

PREFIX  rdfs: <http://www.w3.org/2000/01/rdf-schema#>
SELECT *
WHERE
{ GRAPH ?graph {
<http://vivoweb.org/ontology#vitroClassGrouporganizations> rdfs:label ?label 
}}

 

is this:

NOW EDIT (note that the german label is presented because this form seems to not care about language context)

 

Result after editing:

+Triple situation after editing+ 

uh oh. All the other contexts besides English have been deleted.

chenejac commented 3 years ago

Benjamin Gross said:

I experience something similar when editing menu page labels.

chenejac commented 3 years ago

Brian Lowe said:

https://github.com/vivo-project/Vitro/pull/205/

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/Vitro/commit/1c2d5be01a8f16d16812dc3dc5b1e84eb778ee29