VIVO-396: Preferred title not showing up in Index or Search or People browse page

[chenejac]

Holly Mistlebauer (Migrated from VIVO-396) said:

Relates to RC 1... I added a "Faculty Member" named "Jane Faculty" and set her Preferred Title to "Assistant Professor" (see attached file jane.jpg).

• When I go to the INDEX to look at her display under "Faculty", there is no title listed--her Preferred Title showed up on this page in VIVO 1.5 (see attached faculty.jpg).
• When I go to the INDEX to look at her display under "Persons", there is a default title of "Faculty Member" showing up rather than her Preferred Title of "Assistant Professor" (see attached file person.jpg).
• When I search for "Jane Faculty", the search result lists the default title of "Faculty Member" rather than her Preferred Title of "Assistant Professor" (see attached file search.jpg). (Note: The same thing happened when I added a Librarian.)

[chenejac]

tlw72 said:

The preferred title is being referenced in the following classes.

Vitro:

webapp/src/edu/cornell/mannlib/vitro/webapp/controller/json/JsonServlet.java webapp/src/edu/cornell/mannlib/vitro/webapp/services/shortview/FakeApplicationOntologyService.java webapp/src/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/DataGetterUtils.java

VIVO:

src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/PersonHasPreferredTitleGenerator.java src/edu/cornell/mannlib/vitro/webapp/visualization/utilities/UtilitiesRequestHandler.java src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/IndividualTemplateModel.java src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individuallist/ListedIndividual.java src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/searchresult/IndividualSearchResult.java

[chenejac]

tlw72 said:

As discussed.

[chenejac]

Jim Blake said:

It would be best to create the code once to obtain preferred title, first name, last name, email address from the VCard. But note that VCard is an attribute of the VIVO ISF ontology, and so is inappropriate in Vitro code. So where to put it? How to tie it in?

[chenejac]

Jim Blake said:

Does it make sense to create a VCard bean? Are the values for email, title, etc. frequently used together? If so, it would likely be more efficient to obtain them all through a single query.

[chenejac]

Jim Blake said:

PersonHasPreferredTitleGenerator is already using VCard. IndividualTemplateModel has been updated to use VCard.

---

UtilitiesRequestHandler is part of the visualization code. Currently, it fails to find the preferredName. Is this apparent in the visualizations? How can we test this?

---

ListedIndividual and IndividualSearchResult are trying to read data properties from the Individual (IndividualSearchResult uses email also).

---

JsonServlet contains several references to preferred title, first name, and last name. These are all inappropriate for Vitro and should be moved to VIVO. But is this the time for this task?

DataGetterUtils contains similar (perhaps identical?) code, which is used by IndividualsForClassesDataGetter, which is widely used in turn. -- again, these are inappropriate for Vitro.

But is this the time to move them to VIVO? Or should we kick the can down the road?

[chenejac]

tlw72 said:

I'll take a look at the visualization class and templates and figure out where the title is supposed to be displayed.

[chenejac]

Jim Blake said:

Tim -- this is all set except for the visualization class. You said you would look into that. Let me know what you find.

[chenejac]

tlw72 said:

It turns out that the preferred title is not being displayed in the visualizations in 1.5, though it should have been because there is a placeholder for it in the html. But the vcard business makes the fix more complicated now. Since it's not displaying in 1.5 anyway, I think we should kick this can down the road by (1) commenting out the line referencing the core:preferredTitle predicate (doing so doesn't break anything) and leave as is for 1.6, and (2) creating a new post-1.6 Jira issue for this.

Your thoughts?

[chenejac]

Jim Blake said:

That works for me.

[chenejac]

tlw72 said:

Created post-1.6 VIVO-454 to address the display of the preferred title on co-author and co-investigator visualization pages.

[chenejac]

Holly Mistlebauer said:

Tested in RC2 and works now. Thanks!