search

chenejac / VIVOTestMigrationJIRANotClosed

0 stars 0 forks source link

VIVO-1616: Determine and document what files are required in a theme #159

Open chenejac opened 5 years ago

chenejac commented 5 years ago

Benjamin Gross (Migrated from VIVO-1616) said:

Related to https://jira.duraspace.org/browse/VIVO-1543

-VIVO will currently not run correctly if page.ftl is not included with a theme.- There are likely additional requirements in the theme for VIVO to run. The list of required files should be documented.

Edit - Issue with page.ftl has been resolved

chenejac commented 5 years ago

Mike Conlon said:

Just to be clear.  The "theory of themes" was that fallbacks would be used when the theme did not have a template?  So if page.ftl was not included, a default page.ftl would be used?

Is it possible that page.ftl is not found n the default place VIVO is looking for a fallback?  And then this issue would be be a bug about page.ftl?

When you say "does not run correctly" what is observed?  Doesn't start?  Doesn't display as expected?  Throws an error?

chenejac commented 5 years ago

Benjamin Gross said:

This is a documentation improvement issue, which is separate from the error. I was just using it as an example to justify why the documentation is needed. The problem, including the error, with page.ftl is described in the issue I linked in the issue description [VIVO-1543].

Yes, themes sit on top of fallback/default css and freemarker templates. As far as I know, it's not possible to run VIVO without a theme. An interesting exercise would be to create an empty theme directory and see what works and what doesn't.

chenejac commented 5 years ago

Mike Conlon said:

Will try the empty theme idea.  Yes, I was suggesting this documentation Jira might be unnecessary if the bug is fixed.

chenejac commented 5 years ago

Benjamin Gross said:

Oh okay. I was thinking there were probably other files this happened with. And another but related discussion was if the fallback files should exist at all, and if there is a set of files we consider required for all themes.

chenejac commented 5 years ago

Benjamin Gross said:

The issue with page.ftl was resolved with https://github.com/vivo-project/Vitro/commit/d2c34ddf46cb781a788f71736e67ffd649b56d00 The task of determining if there are other files that must be in a theme for Vitro or VIVO to work still remains.