VIVO-652: Sites with their own themes don't see VIVO-specific language strings

[chenejac]

Jim Blake (Migrated from VIVO-652) said:

Warnings like this appear in the log: 2013-12-20 20:47:04,197 WARN [I18nBundle] Text bundle 'all' has no text for 'co_author' 2013-12-20 20:47:04,200 WARN [I18nBundle] Text bundle 'all' has no text for 'co_author' 2013-12-20 20:47:04,214 WARN [I18nBundle] Text bundle 'all' has no text for 'co_author_network' 2013-12-20 20:47:04,218 WARN [I18nBundle] Text bundle 'all' has no text for 'co_author_network' 2013-12-20 20:47:04,221 WARN [I18nBundle] Text bundle 'all' has no text for 'map_of_science' 2013-12-20 20:47:04,224 WARN [I18nBundle] Text bundle 'all' has no text for 'map_of_science' 2013-12-20 20:47:04,227 WARN [I18nBundle] Text bundle 'all' has no text for 'map_of_science' 2013-12-20 20:47:04,230 WARN [I18nBundle] Text bundle 'all' has no text for 'map_of_science_capitalized'

Errors like this appear on the page: ERROR: Text bundle 'all' has no text for 'only_display' Ground Network ERROR: Text bundle 'all' has no text for 'within_my_institution' ERROR: Text bundle 'all' has no text for 'enable_internal_class_one' ERROR: Text bundle 'all' has no text for 'internal_class' ERROR: Text bundle 'all' has no text for 'enable_internal_class_two'

[chenejac]

Jim Blake said:

This is because VIVO-specific language strings are in the same file as wilma-specific language strings.

Workaround: copy all.properties from [vivo]/themes/wilma/i18n into the corresponding location in their own theme directory.

[chenejac]

Jim Blake said:

Notes for the chat with Brian and Tim 2014/01/06

[chenejac]

Jim Blake said:

Based on the discussion:

• Still not interested in using multiple file hierarchies. Prefer to base it all on all.properties
• Simply move all.properties file from wilma to vivo, using a naming convention to avoid replacing the Vitro file. This means changes to the example language in the repository.
• We still want to recognize all.properties in the theme, if it exists, but not to throw an exception if it does not.
• We may decide to split the strings to appear in the theme. But we also want to reduce the amount of material that appears in the theme.

[chenejac]

Mike Conlon said:

From VIVO-467, a duplicate, which is being closed: Currently, language strings can be stored in all.properties in Vitro, or in all.properties in the theme. However, there are many strings that are used by templates in VIVO that are not in any theme. If the site admin switches to a different theme, these strings are no longer available, and errors appear on the page. I need to establish a scheme by which strings are taken from The theme, VIVO, and Vitro, in that order. But, considering how VIVO and Vitro's code bases are merged, what is the generalized way to make this happen? How do we allow 2-tier and 3-tier builds to supplement the properties files in Vitro without replacing them? Remember that in a 3-tier build, the 3rd tier would override the others (after the theme). Now, we will need to retrofit, which means figuring out which strings are used in VIVO in general, and which ones are used only in the theme.