chenejac / VIVOTestMigrationJIRANotClosed

0 stars 0 forks source link

VIVO-1866: solrconfig.xml included with vivo-solr is missing configuration from pre-1.11 versions #62

Open chenejac opened 4 years ago

chenejac commented 4 years ago

Benjamin Gross (Migrated from VIVO-1866) said:

The solrconfig.xml file intended for VIVO 1.11 (see [https://github.com/vivo-community/vivo-solr/blob/vivo-solr-1.11.0/vivocore/conf/solrconfig.xml]) does not include all the functionality we previously included prior to v1.11.

1.10 version of the file: [https://github.com/vivo-project/Vitro/blob/vitro-1.10.0/home/src/main/resources/solr/conf/solrconfig.xml]

Review the difference between these files and determine if we are missing important functionality. If so, add the functionality back into the config and confirm it still works in modern versions of Solr.

chenejac commented 4 years ago

Benjamin Gross said:

See https://jira.lyrasis.org/browse/VIVO-1865 for a related issue

chenejac commented 4 years ago

Benjamin Gross said:

Created a branch to compare the diff. See it sans whitespace differences here: [https://github.com/vivo-project/vivo-solr/compare/master...testing/solrconfig?w=1]

chenejac commented 4 years ago

Benjamin Gross said:

Random notes on changes

 

From to .

 

Commented out .

1 0

 

false to true   Update log now uncommented  ${solr.ulog.dir:} autoCommit 60000 to  ${solr.autoCommit.maxTime:15000}   50000 to  1024 Note says safe to increase    Feature Values Cache settings (likely unused) [https://github.com/vivo-project/vivo-solr/blob/master/vivocore/conf/solrconfig.xml#L478]   Removed . Likely safe to remove since there's a note saying it was only there for backwards compatibility with old Vitro.    enableRemoteStreaming from true to false. "enables use of the stream.file and stream.url parameters for specifying remote streams." Any reason to have this enabled?  to  Add in AND to search handler.    Removed  Maybe a problem if using SolrCloud? text,features,name,sku,id,manu,cat to text,features,name,sku,id,manu,cat,title,description,keywords,author,resourcename   Add in true Add in  true   Removed  and etag chain. Removed text in textSpelltext_general and removal of changes of spell check, back to default.   Add to suggestComponent: false   Removal of text from trvh component. Vectors? Unused?   Uncommented edismax      
chenejac commented 4 years ago

Andrew Woods said:

There are a lot of differences. I assume we will want to pull many (if not all) of them into the new configuration. As implied by your notes above, we should have a strong understanding of the purpose of any given change before bringing it into the new configuration. This is an important issue, and one that we should take action on soon. How would you like to proceed?