VIVO-1788: i18n: Syntax error on temporal graph visualization page in french, grammar problems.

[chenejac]

Alexander J. Jerabek (Migrated from VIVO-1788) said:

On the temporal graph visualization page the french text reads:

'SVP, consulter le Chimie page de profil complet pour de plus amples informations.'

This follows from the english syntax :

'Please visit the full Chemistry profile page for a more complete overview.'

The phrase should read:

'SVP, consulter la page de profil complète de Chimie pour de plus amples informations.'

-Also, it seems (to me) that there is a missing article here:-

-current text:- -Cette organisation n'a aucune organisation subordonnée ni aucune personne qui lui est associée publications dans le système-

-should be:- -'Cette organisation n'a aucune organisation subordonnée ni aucune personne qui lui est associée [des] publications dans le système.'-

-However, I am uncertain about the correct use of articles here, others may have a better idea-.  moved to https://jira.lyrasis.org/browse/VIVO-1838

Page: [http://[localhost:8080]/vivo/vis/publication-graph/n7257]

[chenejac]

Andrew Woods said:

Sounds like we need more input from the team:

However, I am uncertain about the correct use of articles here, others may have a better idea.

[chenejac]

Nicolas B Dickn said:

Original is "This organization has neither sub-organizations nor people with publications in the system"

Proposed meaningful translation: "Cette organisation n'a aucune organisation subordonnée, ni aucune personne aillant des publications dans le système"

Location of the first part of the string is is vivo_all_fr_CA.properties, line 485. -Am on it.-

Concatenation occurs in the java code. Not sure I can take care of it.

 

[chenejac]

Nicolas B Dickn said:

The point is, I could change

"Cette organisation n'a aucune organisation subordonnée ni aucune personne qui lui est associée"

for

"Cette organisation n'a aucune organisation subordonnée, ni aucune personne aillant des"

but we'd have to check whether that would make sense in all the possible concatenations.

 

[chenejac]

Andrew Woods said:

The only occurrence found (grep -R entity_comp_error_text1 *|grep -v target) in VIVO is: https://github.com/vivo-project/VIVO/blob/sprint-i18n-whitespace/webapp/src/main/webapp/templates/freemarker/visualization/entitycomparison/entityComparisonErrorCommonBody.ftl#L22-L24

[chenejac]

Nicolas B Dickn said:

Sorry, I was not clear. What I meant was : in that specific .ftl file, can the variable ${textForCurrentEntityComparisonType} be something else than "publications" ?

Edit: I had a look at the page, and it looks like there are two possible pieces of data for that variable: either "publications" or "grants".

Which means I could go ahead and safely modify the string on line 485.

!image-2020-04-17-15-07-40-186.png!

[chenejac]

Nicolas B Dickn said:

Moved that specific bug into https://jira.lyrasis.org/browse/VIVO-1838