search

chenejac / VIVOTestMigrationJIRANotClosed

0 stars 0 forks source link

VIVO-1749: Merely displaying the "manage list of websites" (rolodex) page modifies rank data without further action #95

Open chenejac opened 4 years ago

chenejac commented 4 years ago

Brian Lowe (Migrated from VIVO-1749) said:

On an individual page, clicking the rolodex ("manage list of websites") icon under the Websites heading brings up a page where individual vcard:URL links can be reordered via drag and drop.  Merely GETting this page without doing any actual dragging and dropping causes the vivo:rank values for the URLs to be updated according to the order in which the items are initially displayed on the page.  Data should only be modified via appropriate non-GET HTTP requests triggered by actual manipulation of the drag/drop interface by the user.

 

See also https://jira.lyrasis.org/browse/VIVO-1750

for a related example of how this behavior can lead to data corruption in multilingual VIVOs.

chenejac commented 4 years ago

Andrew Woods said:

It appears that this behavior of updating the order/rank of the rolodex webpages on page-load is by design: https://github.com/vivo-project/VIVO/blob/master/webapp/src/main/webapp/templates/freemarker/edit/forms/js/manageWebpagesForIndividual.js#L29-L33