search

chenejac / VIVOTestMigrationJIRANotClosed

0 stars 0 forks source link

VIVO-1748: Remove "RDF description of" from rdfs:label #96

Open chenejac opened 4 years ago

chenejac commented 4 years ago

Christian Hauschke (Migrated from VIVO-1748) said:

curl -LH'Accept: text/turtle' [https://vivo.tib.eu/fis/individual/n0000-0003-2499-7741]

... or any other VIVO URI. Output:

<[https://vivo.tib.eu/fis/individual/n0000-0003-2499-7741/n0000-0003-2499-7741.ttl]>   a foaf:Document ;  rdfs:label "RDF description of [https://vivo.tib.eu/fis/individual/n0000-0003-2499-7741]" ;  dc:date "2020-03-10T08:48:47"^^xsd:dateTime ;  dc:publisher <[https://vivo.tib.eu/fis]> ;  dc:rights <[https://vivo.tib.eu/fis/termsOfUse]> .

"RDF description of" should be removed as a part of rdfs:label. According to [https://www.w3.org/TR/rdf-schema/#ch_label:]

rdfs:label is an instance of rdf:Property that may be used to provide a human-readable version of a resource's name.

Most likely the change should be done in the following files:

[https://github.com/vivo-project/Vitro/blob/6d64d27fe4ad26bee7ffd10a852e71240f8ae903/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individual/IndividualRdfAssembler.java#L351]

[https://github.com/vivo-project/Vitro/blob/6d64d27fe4ad26bee7ffd10a852e71240f8ae903/api/src/test/java/edu/cornell/mannlib/vitro/webapp/controller/individual/IndividualRdfAssemblerTest.java#L305]

[https://github.com/vivo-project/Vitro/blob/6d64d27fe4ad26bee7ffd10a852e71240f8ae903/api/src/test/resources/edu/cornell/mannlib/vitro/webapp/controller/individual/IndividualRdfAssemblerTest.filteredRdf.n3#L150]

[https://github.com/vivo-project/Vitro/blob/6d64d27fe4ad26bee7ffd10a852e71240f8ae903/api/src/test/resources/edu/cornell/mannlib/vitro/webapp/controller/individual/IndividualRdfAssemblerTest.unfilteredRdf.n3#L167]

Thanks to Sarven who pointed this out.

chenejac commented 4 years ago

Andrew Woods said:

[~accountid:6113d5edb704b400686dc540]: It would seem (according to the definition of '3.6 rdfs:label') that the entire VIVO rdfs:label triple should be removed from the example above, no? Or better yet, the object of the rdfs:label should be an appropriate literal value, such as the individual's name.