chengchingwen / Pickle.jl

An experimental package for loading and saving object in Python Pickle format.
MIT License
51 stars 9 forks source link

Allow `Strided@2`? #39

Closed mcabbott closed 4 months ago

mcabbott commented 6 months ago

I haven't tried to use this package, but it is loaded by MLDataSets, and loads Strided.jl at v1, which holds back other things. Can it allow Strided v2?

Locally tests fail, so I did not try out the change:

[ Info: protocal 4
[ Info: Test NP
load: Error During Test at /Users/me/.julia/packages/Pickle/hQSk8/test/test_np.jl:16
  Test threw exception
  Expression: jlscalars[1] == tryparse(UInt32, pyconvert(Any, (npscalars[1]).__repr__()))
  type UInt32 has no field __repr__

Xref https://github.com/Jutho/Strided.jl/issues/25 maybe.