chengchingwen / Transformers.jl

Julia Implementation of Transformer models
MIT License
526 stars 75 forks source link

update NNlib and Flux compat #153

Closed CarloLucibello closed 5 months ago

CarloLucibello commented 1 year ago

This package is incompatible with Flux 0.14 and NNlib 0.9. Can the compatibility be updated?

chengchingwen commented 1 year ago

What are the breaking changes beside dropping julia 1.6 and using package extension?

CarloLucibello commented 1 year ago

Just the extension thing. So NNlibCUDA is deprecated, and for CUDA support in Flux one has to explicitly load CUDA.jl

CarloLucibello commented 1 year ago

I think the only required change here is to drop NNlibCUDA and to increase julia compatibility to >= 1.9.

chengchingwen commented 1 year ago

Yes, but I'm a little worried about dropping julia < 1.9.

CarloLucibello commented 1 year ago

Julia 1.9 changed many things. I'm sure those interested in getting package updates are already using it. On the other hand, it seems more problematic not to get Flux and NNlib updates if you have this package in your environment.

originalsouth commented 1 year ago

Yes, but I'm a little worried about dropping julia < 1.9.

@chengchingwen can you please elaborate?

chengchingwen commented 1 year ago

@originalsouth Simply because julia 1.6 is the LTS version.

originalsouth commented 1 year ago

I guess most FluxML packages as Flux.jl has dropped that support already... perhaps an LTS branch for this repository can mediate the conflict of interests?

johannes-fischer commented 7 months ago

6 months later, any updates on updating Flux compat? I think this is long overdue