chenghuzi / doc-optuna-chinese

超参数优化框架Optuna的中文文档
MIT License
2 stars 1 forks source link

Some review comments on FAQ #1

Open belldandyxtq opened 4 years ago

belldandyxtq commented 4 years ago
  1. https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L26 How about (某某是你常用的机器学习库). also we may want to be consistent on the terms, like 机器学习库 or ML库 https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L34
belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L39 I am not sure about the 独有参数, I get the idea since I read the English version first. How about 额外参数 to be consistent with https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L55

belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L47 How about 首先,如下例,可调用的 objective 类具有这个功能:

belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L55 I think 或者 feels better here.

belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L81

  1. typo 的话
  2. How about 你也可以很方便地使用SQLite来储存到本地磁盘:
belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L142

How about Optuna 会保存超参数和对应的目标函数值,但是它不会存储诸如机器学习模型或者网络权重这样的中间数据。 Similarly about 机器学习库 or ML库

belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L151 . =>

belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L168 I think it means 即使如此,请仍注意以下两点

belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L231 It seems just repeats the previous line. How about 你也可以通过查看trial的状态来找到他们

belldandyxtq commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L327 How about 如何在两块 GPU 同时跑不同的两个 trial

belldandyxtq commented 4 years ago

Is faq unfinished. I found https://optuna.readthedocs.io/en/latest/faq.html#how-do-i-avoid-running-out-of-memory-oom-when-optimizing-studies is missing

chenghuzi commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L81

1. typo `的话`

2. How about `你也可以很方便地使用SQLite来储存到本地磁盘:`

Indeed active voice sounds better, but how about 你可以轻松地将 SQLite 用作本地存储。 and remove in the first part.

chenghuzi commented 4 years ago

https://github.com/chenghuzi/doc-optuna-chinese/blob/2004a3a7b56f7c5d29d1fecc689f387cbfced84a/source/locale/zh/LC_MESSAGES/faq.po#L151

. =>

This is a complex and long-standing typography issue, especially when we're using both English and Chinese characters in the same article ... Here I follow a rule to use for all sentences ending with an Chinese character and . in other cases.

But this is not the only way, we can discuss this later.

chenghuzi commented 4 years ago

Is faq unfinished. I found https://optuna.readthedocs.io/en/latest/faq.html#how-do-i-avoid-running-out-of-memory-oom-when-optimizing-studies is missing

In the version (v1.4?) of doc I used, there's no out-of-memory stuff. Probably we can add it later.

chenghuzi commented 4 years ago

Partially resolved in this commit.