Remote Selenium server and Browser name screenshots

chenglou / node-huxley

Codeless front-end testing.

MIT License

361 stars 29 forks source link

Remote Selenium server and Browser name screenshots #40

Closed brentwalter closed 10 years ago

brentwalter commented 10 years ago

Enabled passing remote Selenium server from command line option
Enabled browser name to be appended to screenshots

chenglou commented 10 years ago

omg =D... Really busy and can't test this right now, but thanks a lot! Can you separate this into two PRs though?

brentwalter commented 10 years ago

I'll try to separate the two features in individual pull requests. Thanks for considering the PRs.

marplesoft commented 10 years ago

+100 for this :)

chenglou commented 10 years ago

Bah you know what? Don't bother. I'm merging this in and testing them =) I'll most likely make a few slight changes, e.g. changing the way naming is done (firefox.3.png -> firefox 3.png). But the rest looks good. Again, thanks a lot!