chenglou / node-huxley

Codeless front-end testing.
MIT License
361 stars 29 forks source link

Add BrowserStack support. #51

Closed mCzolko closed 10 years ago

mCzolko commented 10 years ago

You can test from CI thru BrowserStack. If you merge this, I'll sent you a pull request on grunt-huxley with updated README

chenglou commented 10 years ago

What does setCapabilities do?

mCzolko commented 10 years ago

it just set additional data for create webdriver

mCzolko commented 10 years ago

data like this:

var capabilities = {
  'os' : 'Windows',
  'os_version' : 'XP',
  'browser' : 'IE',
  'browser_version' : '7.0'
}
mCzolko commented 10 years ago

maybe i should rename setCapabilities to setBrowserStackCapabilities

mCzolko commented 10 years ago

We can run test recording on our local machine, render is different on platforms. We need to use third party browser to run the tests correctly. Please merge this PR. Thank you!

chenglou commented 10 years ago

Hey, a bit busy here with work. I'll check this this weekend. Although I'm a bit hesitant on providing a particular third-party support directly.

mCzolko commented 10 years ago

It is same third-party as Selenium webdriver. Another solution is to provide some option to inject my own webdriver to node-huxley. Actually I really appriciate what have you done, honestly. This is a great tool. But really need this, we are working in team on project (few guys are not developers, they dont know how to run selenium and project itself).

chenglou commented 10 years ago

I'm definitely down for providing a way to inject your plugin. Would be even better if you do this lol. If not, I'll check this out this weekend. (Btw, you can always point package.json to your fork's url, so you can get stuff running while waiting on PR merges here). I'll also check out browserstack to see what it does.

chenglou commented 10 years ago

On a related note, I understand your pain with Selenium. But I haven't found another non-headless browser yet. Not sure one even exists? I'm slowly pulling this apart more so that you can assemble stuff you want together, e.g. in the future you'll be able to only take the browser actions tracking part and plug your own stuff in. Meanwhile, Injecting the dependency doesn't sound too bad =).

mCzolko commented 10 years ago

So, what we gonna do? :)

chenglou commented 10 years ago

Imma pick the injection way! I'll see how to do it (Sorry but is it blocking for you? Like I said, you can still point package.json to your fork for your project so no need to wait for me on this).

mCzolko commented 10 years ago

OK, I'll close this pull request and send you a another one with injection. It is a little blocker for me, but I want to share my thoughts with you in first place.