search

chenglou / node-huxley

Codeless front-end testing.
MIT License
361 stars 29 forks source link

Don't use the openDummy technique with injected drivers. #66

Closed SlexAxton closed 10 years ago

SlexAxton commented 10 years ago

I think the entire technique may be able to be retired entirely since we're not taking screenshots of the whole browser ui, but just in case, this just disables it for external driver situations. We could also just reuse the 'driver' function and create a new injectedDriver, but in situations like in sauce or browserstack, this would spin up an entirely unrelated session.

More specifically, there's no guarantees of a serverUrl or anything when an external driver is being used. For me, this caused ECONNREFUSED errors in the dummy driver because it didn't have anywhere to connect.

chenglou commented 10 years ago

Looks good to me, but I'll hold on before pulling this in. We might not need the dummy anymore at all if we do #65.

chenglou commented 10 years ago

Sorry for the wait. 0.8.0 is out and thanks to local comparison there's no more need for openDummy (it only checks that the screenshots are consistent before/after your local changes). I'll close this out!