search

chenglou / react-motion

A spring that solves your animation problems.
MIT License
21.68k stars 1.15k forks source link

Reexport flow types from src #533

Closed TrySound closed 6 years ago

TrySound commented 6 years ago

This way allows to avoid copying source files and just reuse them for flow types.

If you don't have enough time to maintain this project, I could take care at least about build step and make output smaller. This is important for me since this project is a dependency of react-beautiful-dnd

/cc @chenglou @nkbt

TrySound commented 6 years ago

Ping guys. I want to make this project even better.

Here's example of my open source work https://github.com/bvaughn/react-virtualized/commits?author=TrySound

/cc @chenglou @nkbt

TrySound commented 6 years ago

You guys suck in maintaining so popular project.

nkbt commented 6 years ago

Yep, I certainly do. Life and things, you know ¯_(ツ)_/¯ -- Nik Butenko nik@butenko.me http://github.com/nkbt

kentcdodds commented 6 years ago

I want to make this project even better.

That's great!

You guys suck in maintaining so popular project.

Please don't say things like this. It's never appropriate and is a total jerk-move. Instead you could ping the maintainers again and offer to help maintain the project. If you still get no response then a fork would be appropriate (and perhaps a merge in the future).

I hope you all have a better day :)

chenglou commented 6 years ago

Removing such a dependency is nice. Thanks for the PR @TrySound. I'll merge it. Sorry for the long wait

TrySound commented 6 years ago

Yay. Cool. That worked. Sorry for my words.

chenglou commented 6 years ago

All good =)