search

chenglou / react-motion

A spring that solves your animation problems.
MIT License
21.68k stars 1.15k forks source link

Upgrade stack #545

Closed TrySound closed 5 years ago

TrySound commented 6 years ago

I wanted to upgrade only babel but everything else was broken so I upgraded babel, webpack, eslint and karma.

Disabled a lot of eslint rules to not change existing code. Maybe it's better to migrate to prettier later.

This changes will unblock me from providing smaller output.

TrySound commented 6 years ago

/cc @chenglou

TrySound commented 6 years ago

We need to rerun travis

TrySound commented 5 years ago

Friendly ping @chenglou

chenglou commented 5 years ago

Thanks for the ping. To be clear, is there a user-facing change here? Or just for us devs?

TrySound commented 5 years ago

@chenglou This one only for devs.

TrySound commented 5 years ago

Bundle is slightly changed with new versions of webpack/babel but I don't think there's anything significant.

TrySound commented 5 years ago

@chenglou Tests are passed.

chenglou commented 5 years ago

If there's no user-facing impact then sure. Thanks!