search

chenglou / react-motion

A spring that solves your animation problems.
MIT License
21.68k stars 1.16k forks source link

Warning in React.StrictMode #559

Closed xiaody closed 3 years ago

xiaody commented 5 years ago 
componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Motion, TransitionMotion

Learn more about this warning here:
https://fb.me/react-strict-mode-warnings
nkbt commented 5 years ago

There is a PR https://github.com/chenglou/react-motion/pull/534 already. I haven't seen much real world testing on it yet and not sure how much stuff is going to be broken unfortunately =(

xiaody commented 5 years ago

Well, if there isn't a release, how can anyone easily test on it? What about a test release like 0.6.0-alpha.0?

nkbt commented 5 years ago

one can always install it from pr/git hash, it is not necessary to release to test it,

xiaody commented 5 years ago

A test release indicates that is official and at least well reviewed. Never mind, I have moved to https://github.com/drcmda/react-spring.

nkbt commented 3 years ago

Close as duplicate of https://github.com/chenglou/react-motion/issues/569#issuecomment-780190833