Code in npm is different than github repo

fabiulous commented 5 years ago

I got into an issue with setState in a unmounted component and tracked down the issue to this: https://github.com/chenglou/react-motion/pull/305

The 0.5.2 version in this repo has the following check in Motion, TransitionMotion and StaggeredMotion:

if (this.unmounting || this.animationID != null) {
  return;
}

I took a look at the code in my node_modules and noticed Motion doens't have the this.unmounting flag nor the code above.

I have 0.5.2 in my package.json and in node_modules/react-motion there's indeed 0.5.2 in package.json but there's 0.5.1 in bower.json

It looks like the code published in npm is outdated

roderickhsiao commented 5 years ago

yes, we have a discussion

Will need the author or maintainer to help on this :)

nkbt commented 3 years ago

chenglou / react-motion