chenglou / react-motion

A spring that solves your animation problems.
MIT License
21.7k stars 1.16k forks source link

Maintain the same build file paths #578

Closed nkbt closed 5 years ago

nkbt commented 5 years ago

Closes #577

Had to update all the babel stuff, so versions match, I've tested new built version with my other app and it looked good. If anyone can try this too - would be nice.

Notes

Currently published version

find ./node_modules/react-motion
./AUTHORS
./bower.json
./build
./build/react-motion.js
./build/react-motion.map
./HISTORY.md
./lib
./lib/mapToZero.js
./lib/mapToZero.js.flow
./lib/mergeDiff.js
./lib/mergeDiff.js.flow
./lib/Motion.js
./lib/Motion.js.flow
./lib/presets.js
./lib/presets.js.flow
./lib/react-motion.js
./lib/react-motion.js.flow
./lib/reorderKeys.js
./lib/reorderKeys.js.flow
./lib/shouldStopAnimation.js
./lib/shouldStopAnimation.js.flow
./lib/spring.js
./lib/spring.js.flow
./lib/StaggeredMotion.js
./lib/StaggeredMotion.js.flow
./lib/stepper.js
./lib/stepper.js.flow
./lib/stripStyle.js
./lib/stripStyle.js.flow
./lib/TransitionMotion.js
./lib/TransitionMotion.js.flow
./lib/Types.js
./lib/Types.js.flow
./LICENSE
./package.json
./README.md

cat node_modules/react-motion/package.json | jq .version
"0.5.2"

This change

$ npm pack
react-motion-0.5.2.tgz

$ npm install "<...>/react-motion/react-motion-0.5.2.tgz"
<...>
+ react-motion@0.5.2
added 10 packages from 48 contributors in 2.211s
found 0 vulnerabilities

$ find ./node_modules/react-motion
./AUTHORS
./bower.json
./build
./build/react-motion.js
./build/react-motion.min.js
./HISTORY.md
./lib
./lib/mapToZero.js
./lib/mapToZero.js.flow
./lib/mergeDiff.js
./lib/mergeDiff.js.flow
./lib/Motion.js
./lib/Motion.js.flow
./lib/presets.js
./lib/presets.js.flow
./lib/react-motion.js
./lib/react-motion.js.flow
./lib/reorderKeys.js
./lib/reorderKeys.js.flow
./lib/shouldStopAnimation.js
./lib/shouldStopAnimation.js.flow
./lib/spring.js
./lib/spring.js.flow
./lib/StaggeredMotion.js
./lib/StaggeredMotion.js.flow
./lib/stepper.js
./lib/stepper.js.flow
./lib/stripStyle.js
./lib/stripStyle.js.flow
./lib/TransitionMotion.js
./lib/TransitionMotion.js.flow
./lib/Types.js
./lib/Types.js.flow
./LICENSE
./package.json
./README.md
./src
./src/mapToZero.js
./src/mergeDiff.js
./src/Motion.js
./src/presets.js
./src/react-motion.js
./src/reorderKeys.js
./src/shouldStopAnimation.js
./src/spring.js
./src/StaggeredMotion.js
./src/stepper.js
./src/stripStyle.js
./src/TransitionMotion.js
./src/Types.js

Visual diff

image

nkbt commented 5 years ago

Found that babel does not process modules and we end up with es6 modules in lib/. Working on it

nkbt commented 5 years ago

Babel build updated, here is the diff (old left, new right) for one of the small modules. Looks good now.

image

chenglou commented 5 years ago

I'm a bit out of touch here, so I'll just stamp this. Looks fine and thanks for your work, as always

nkbt commented 5 years ago

As nobody expressed any more concerns, I reckon it's good to go, we should be able to publish patch version without breaking anything

theopak commented 5 years ago

yay! thanks

nkbt commented 5 years ago

I cannot publish though.

theopak commented 5 years ago

ahhhhh, @chenglou would it be possible to publish?

chenglou commented 5 years ago

Humm I'm pretty sure @nkbt can publish? Am I misunderstanding this

nkbt commented 5 years ago

I’ll check that (will do some ‘next’ publish first to be sure). I thought npm was rejecting it long time ago, might have changed actually.