search

chenglou / react-radio-group

Better radio buttons.
MIT License
445 stars 75 forks source link

Refactor and add RadioButton component #37

Closed Horat1us closed 7 years ago

Horat1us commented 7 years ago

See example and readme for details

nkbt commented 7 years ago

Was it meant to be a pr for different fork?

Horat1us commented 7 years ago

This fork has 100% same API. If this pull request will be accepted I will use this repository.

nkbt commented 7 years ago

To me this is a completely different API and a different library. The fact that is still keeps the previous code to serve old API does not change it.

PS: and just in case all the naming and authors changed too...

Generally if the library has a different API it should be considered, well, a different library. You'd better not have 2 different APIs doing same thing in a single library.

danielberndt commented 7 years ago

I believe react-radio-group's goal is to be as low level as possible so others can build on top of it. While your additions might be helpful to a lot of people, I don't think it's a generic enough solution to be helpful for everyone. So I'm in favour of you releasing this as a separate library and then maybe the README of react-radio-group could add a list of projects which add useful functionality.

nkbt commented 7 years ago

One of main goal was to explore this new (for the time) approach of rendering children as function. Plus what @danielberndt said

Sorry, but will close the pr