search

chenglou / react-state-stream

React animation on steroid.
362 stars 19 forks source link

Allow to add items in third example #5

Closed gaearon closed 9 years ago

gaearon commented 9 years ago

Fixes #4 by specifying initial enter values. Adds "Add Item" button to test entering animation. Awesomely enough, can de-enter.

gaearon commented 9 years ago

This is really getting fun.

  1. Remove all items
  2. Add one item (it'll be 'a')
  3. Start removing 'a' and as it happens press "Add item"
  4. 'a' goes back!
chenglou commented 9 years ago

See here: https://gist.github.com/chenglou/40b75d820123a9ed53d8#stress-tests

That third example is a barebone prototype to show de-unmounting. I don't wanna bloat it up and make it hard for others to understand. Ultimately I'll abstract the whole thing out into a TransitionGroup component and hopefully React can adopt it in the future.

The more complicated stress test (2) will be made, but I wanna keep the 3rd demo simple. There are more bugs than that btw; they might be a wont fix, I'll see.

Edit: oh wait, did you just implement that in your other PR? Wow lol, I'll check

gaearon commented 9 years ago

Closing: out of scope