search

chenglou / react-tween-state

React animation.
Other
1.74k stars 70 forks source link

#47 Adds doc to README that ie9 and phantomjs need polyfill #48

Closed chaseadamsio closed 8 years ago

chaseadamsio commented 9 years ago

Might be worth noting in the docs that a shim for requestAnimationFrame is necessary for older browser support and providing a shim in this situation.

chenglou commented 9 years ago

How about just using that raf polyfill internally then?

chaseadamsio commented 9 years ago

I've talked with some other folks from my team and internally we're asking Application level developers to polyfill based on their needs. If you think that's a solution you'd prefer, I'm happy to patch that and push the change, but I think that decision is entirely up to you based on how you want developers to handle it. Whatever you decide, I'd be happy to do the legwork.

chenglou commented 9 years ago

React-motion (my spring library) comes with raf polyfill internally. It's not that many bytes so I don't see why not =). Let's use the polyfill then.

danieljuhl commented 8 years ago

Or we could simply fallback to setTimeout ? No matter which solution, I think this one needs to be addressed - as IE9 is not the only browser not supporting requestAnimationFrame