egillespie
commented
3 years ago You have something really solid going here, Chengming. I see two levels of routes, valid HTML, short links without .html in their names... quality start! 👍
Here are some recommendations for improvement. Can you try these out?
Move /list-all/index.html to /list/index.html
One feature about nesting routes is that the intermediate routes can be used as navigational pages to explore deeper into a subject. I think you could capture that on your site quite nicely by moving the /list-all/index.html file to /list/index.html.
Can you make this change and update your links to point at the new location for that file?
Use descriptive names for routes and link text
I can't really tell the difference between /list-all and /list just by reading the names, and the link text "My list page" on your pages is generic enough that it doesn't give me a good sense of what the list will contain.
Would you mind coming up with more descriptive names for your /list route and "My list page" link text?
After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.
Thanks! 💻
chengming-1
Build a fansite for books, movies, video games, or anything else
@egillespie Can you take a look at this? It's hosted here and meets the following criteria:
.html/pokemon) -- each list item should link to the corresponding page for that favorite, detailed below/pokemon/bulbasaur) -- we want to make sure you practice multiple levels of nested routes