Project Feedback

[chengming-1]

Build a dating profile generator

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] Use this base HTML (feel free to change it) to build a simple app that generates the HTML for a dating profile in this format, using information collected from the user
• [x] Show a preview of the dating profile with rendered HTML (e.g. <em>hella charming</em> should appear as hella charming)
• [x] Also show the raw, generated HTML inside the <pre><code></code></pre> elements (e.g. <em>hella charming</em> should appear as <em>hella charming</em>)
• [x] Both the preview and raw HTML should update live as the user enters their information
• [x] All JavaScript is in a separate .js file
• [x] There are no linting errors in your JavaScript (this will also be expected for all future projects)

[egillespie]

Your solution is looking really nice, Chengming! I like the function and variable that avoid duplicating a lot of code and can see the profile updating in real-time. Sweet! 🤘

There are two touch-ups I'd like you to make to the profile before I ship this. Here's a screenshot demonstrating both:

1. Show the "Hi, my name is Erik Gillespie" part in <h1>..</h1> tags to match the provided template
2. Replace EMAIL_ADDRESS and PHONE_NUMBER in the href attributes with the typed values

Comment back if you need tips or another review. You've got this! 🤘

[chengming-1]

fixed

[egillespie]

Nice, the heading looks good now and I see some adjustment to the links. It appears that the href attributes are always set to mailto: and tel: though, instead of mailto:gille143@msu.edu and tel:555-1234 or whatever else I type in the email and phone fields.

Can you add the typed values to those href attributes?

[chengming-1]

done

[egillespie]

Nailed it. Awesome! 🔨 :shipit: