[Intro to iOS] Assignment 2 - Review my app #2

[chengyin]

My app is complete, please review. /cc @codepathreview

[nickai]

:+1: Excellent work Chengyin! The primary goals of this homework are to learn how to use AutoLayout to build adaptive UI's that work across many different screen sizes and orientations and to get practice using the delegate pattern. If you haven't already, I recommend going back and running your Yelp app again while rotating the device / simulator to ensure your AutoLayout constraints function as expected.

A couple notes after checking out your code / gif:

• Great to see you wrap long restaurant names on multiple lines of text!
• It's a good practice to use Images.xcassets to host all of your image resources.
• Very clean code to implement the different filters!
• You might want to consider having a business property in your BusinessTableViewCell and then using a "property observer" to configure the cell instead of having a separate showBusiness method.

Here's our general Yelp assignment feedback guide:

• Did you make sure to use AutoLayout for all your layouts? All screens should contain AutoLayout constraints. Make sure to resolve any AutoLayout constraint warnings.
• Did you try rotating the device / simulator to make sure your AutoLayout constraints are set up properly? To rotate the simulator you can use Cmd-Left Arrow or Cmd-Right Arrow. Rotating the screen is a great way to see if you set up your constraints properly.
• Did you make sure to put all image assets inside Images.xcassets? Using the asset catalog is the best practice for storing images. This also lets you keep multiple versions of each image for the necessary screen resolutions (1x, 2x, and 3x).
• Did you configure your custom Business cell to have a single YelpBusiness property? Your custom Business cell should have a property of type YelpBusiness. In the custom setter, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Did you represent the Yelp Filters using custom Model classes? Building custom model classes to represent entities in your app makes them easier to work with and reuse throughout your app.
• Did you create a FiltersViewControllerDelegate? The main view controller and the filters view controller should be connected via a custom filter delegate. This is a popular pattern for handling events between view controllers.
• Did you properly create a form in the filter view controller? Make sure the cells are being recycled and dequeued and appropriately linked to the model. See this popular form library for an alternative to implementing forms manually.
• Did you handle the case where a user cancels out of the Yelp Filters screen? You'll need to make sure you are editing a copy of the Yelp filters when the user edits settings on the Filters page so that when the user cancels out of this screen you can restore the original settings. While connecting the filter view controller directly to a global filter settings is convenient, the downside is if you cancel the filters, the values have already been saved.
• Did you animate the dropdown of expandable filter settings? TableViews have a set of methods that allow you to reload/insert/delete rows and sections of a TableView with an animation (one example is reloadRowsAtIndexPaths:withRowAnimation:).
• Did you configure your table in FiltersViewController using multiple sections? By having multiple sections in your TableView, you can use tableView:titleForHeaderInSection: to add a title to each section.