search

chenhsi / Ambroscum

An interpreter/compiler for a programming language we're probably going to create
MIT License
0 stars 0 forks source link

Conventions for usage of TokenStream #20

Closed edgao closed 2 years ago

edgao commented 10 years ago

Should probably standardize the structure of TokenStreams being passed from Expression into the various Expression subclasses. E.g.: For something of the form "[expression]", do we pop the opening bracket? Or just in general, do we pop things like dots, parentheses, etc.? Or do we rely on the Expression subclasses to ignore them?

chenhsi commented 10 years ago

Hmm, I don't have a particular preference. I think that leaving them for the subclasses might make more logical sense, but I think I had felt that it would be more difficult for Expression to handle. I'm not sure why I felt this, however, so change as you wish.

edgao commented 2 years ago

closing this because I want to clean out my issues view and I think we've basically abandoned this lol