chenqingyu / auto-sub

Automatically exported from code.google.com/p/auto-sub
0 stars 0 forks source link

Cannot enter shows with a : in the name in the Skipshow section #118

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use the web interface of Auto-Sub.
2. Config -> Skipshow.
3. Enter "CSI: Miami = 0" in the input textbox.
4. Click save

What is the expected output? What do you see instead?
I expect the show to be skipped when searching for subtitles. The auto-sub 
script itself crashes instead, and is no longer accessible via the web 
interface.  Checking the config.properties file shows the following line:
csi = miami = 0
instead of what I would expect
csi: miami = 0

What version of the product are you using? On what operating system?
Beta 0.5.5 on a Synology DiskStation with DSM 4.0

Please provide any additional information below.
Some relevant bits from the log

DiskStation> Traceback (most recent call last):
  File "/volume1/@appstore/auto-sub/autosub/Scheduler.py", line 21, in __init__
    self.command.run()
  File "/volume1/@appstore/auto-sub/autosub/scanDisk.py", line 101, in run
    walkDir(str(autosub.ROOTPATH))
  File "/volume1/@appstore/auto-sub/autosub/scanDisk.py", line 53, in walkDir
    if autosub.Helpers.SkipShow(title, season, episode) == True:
  File "/volume1/@appstore/auto-sub/autosub/Helpers.py", line 194, in SkipShow
    elif int(seasontmp) == int(season):
ValueError: invalid literal for int() with base 10: 'miami = 0'

Original issue reported on code.google.com by rd.di.gi...@gmail.com on 25 Jul 2012 at 7:24

GoogleCodeExporter commented 9 years ago
You can't even have files with the : character included, so there will be no 
download that has this. I see no reason that you want to skip a show with : in 
it.

The CSI: Miami episodes are called CSI.Miami.S10E19.720p.HDTV.X264-DIMENSION, 
for example, so you need to skip 'csi miami = 0' not 'csi: miami = 0'.

Original comment by Donny.va...@gmail.com on 26 Jul 2012 at 3:59

GoogleCodeExporter commented 9 years ago
Ok, thanks for the explanation. I'll enter the show names without the : sign.

Still, to avoid having AutoSub crash on these inputs, perhaps they can be 
filtered before writing them to the config file. The input textbox tells you to 
enter the show name, and some shows do have that : sign in the title. 

Original comment by rd.di.gi...@gmail.com on 26 Jul 2012 at 7:28

GoogleCodeExporter commented 9 years ago
I agree, the : character needs to be ignored so it doesn't crash AutoSub.

Original comment by Donny.va...@gmail.com on 27 Jul 2012 at 2:24

GoogleCodeExporter commented 9 years ago
Already an issue with the same problem, agree that it should be fixed, merge 
into issue 110

Original comment by romke.va...@gmail.com on 29 Jul 2012 at 8:35