chenqingyu / auto-sub

Automatically exported from code.google.com/p/auto-sub
0 stars 0 forks source link

Option to ignore old files #154

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I've sometimes series where an English sub is found, but no Dutch sub. They do 
stay in the "Wanted" list forever. As I've seen the serie already with the 
Enlish sub, I don't care about the Dutch anymore and would like to see them 
disappear after a while.
Basically I want auto-sub to download subs only for new files, not try to fetch 
them for old files.

So the option I would like to see: "only download subtitles if the file is not 
older than x weeks"

Original issue reported on code.google.com by tom.bill...@gmail.com on 21 Nov 2012 at 2:43

GoogleCodeExporter commented 9 years ago
How about you just skip the season(s) of series you don't want in Auto-Sub 
anymore?

Original comment by Donny.va...@gmail.com on 21 Nov 2012 at 4:49

GoogleCodeExporter commented 9 years ago
That's an option. However, the suggested approach has some advantages
* no need to care about ignoring a session after it's done (maintenance)
* only possible to ignore files once the season is completed
* this approach also ignored old files I've in my folders that contain 
unparsable files

As I had a little time, I've hacked it in myself, patch attached.

Original comment by tom.bill...@gmail.com on 21 Nov 2012 at 8:31

Attachments:

GoogleCodeExporter commented 9 years ago
Nice, does this work on the windows version? If so, how? :)

Original comment by arvanv...@gmail.com on 21 Nov 2012 at 11:05

GoogleCodeExporter commented 9 years ago
I'm using it only on linux (Ubuntu 12.04.1 LTS 64bit), but I would guess it 
would work on windows too. Only difference is that os.path.ctime returns 
"creation" time on windows, while on other oses it returns modification time: 
http://docs.python.org/2/library/os.path.html#os.path.getctime

Original comment by tom.bill...@gmail.com on 22 Nov 2012 at 7:00

GoogleCodeExporter commented 9 years ago
Thanks, for sharing. I already though of this feature a long time ago. The 
problem with it that it should be possible to allow skip 1 show from the ignore 
old check. For example, i know that Dexter take the translaters a long time to 
translate so I want that should to have an ignore time of 2 month but default I 
want every show to be skipped after 1 month etc etc.
Thus I should be able to set a specific ignore duration for each show. This 
requires a new construction in the wanted list which is currently a simple 
dictionary. It requires a lot more work than your patch, but it is a start. 

I haven't accepted this feature yet, because I have to think about it a little 
bit more.

Original comment by romke.va...@gmail.com on 22 Nov 2012 at 11:11

GoogleCodeExporter commented 9 years ago
Glad you appreciate it.
In my opinion this could be 2 different things though. The feature I 
implemented just bluntly skips old "files", while you suggest to skip old 
"episodes/series"

While yours is more flexible, I see some added values in mine too:
* It also solves the "problem" of unparsable files that always end up in the 
log when scanning. Not really a big issue, but annoyed me a bit.
* It might solve the "support for multiple path" feature a bit. The reason why 
I wanted this option is because when I did setup auto-sub I had a horrible 
amount of series that were in the todo-list, and it took me quite some time to 
ignore them all for the old series. If this option would have been disabled it 
would have been almost not an issue.

Original comment by tom.bill...@gmail.com on 23 Nov 2012 at 8:51

GoogleCodeExporter commented 9 years ago
I will implement this one way or another. Accepted.

Original comment by romke.va...@gmail.com on 7 Feb 2013 at 12:02