chenqingyu / auto-sub

Automatically exported from code.google.com/p/auto-sub
0 stars 0 forks source link

Wrong order in showId determination in checkRss #44

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
checkRss.py order of showId determination results in not being able to override 
showid via namemapping :

-- checkRss.py :

                    if not wantedItemtitle in autosub.SHOWID_CACHE.keys():
                        showid = autosub.Bierdopje.getShowid(wantedItemtitle)
                        if not showid:
                            log.debug("checkRSS: Could not be found on bierdopje.com for %s, trying the namemapping" % wantedItemtitle)
                            showid = autosub.Helpers.nameMapping(wantedItemtitle)
                            if not showid:
                                log.error("checkRSS: Could not find a show ID for %s" % wantedItemtitle)
--

E.g. for Once.Upon.a.Time.S01E11.720p.HDTV.X264-DIMENSION.mkv -> 
wantedItemtitle='Once upon a time' the checkRss code above is already finding a 
(wrong) showid of 15849 at Bierdopje (real showId is 15202), the 
showId=autosub.Helpers.nameMapping code is never reached, so overriding via 
nameMapping is not possible.

The (similar) code in checkSub.py does first check the local nameMapping 
instead of Bierdopje.getShowid, but since checkRss already populates the 
SHOWID_CACHE before checkSub is being executed, the nameMapping code is also 
not reached there (as in checkSub it first checks the SHOWID_CACHE)

Solution I think is to first check local nameMapping in checkRss just as is 
being done in checkSub, or even first check the local nameMapping even before 
the SHOWID_CACHE.

Original issue reported on code.google.com by Simon.Ve...@gmail.com on 15 Feb 2012 at 7:35

GoogleCodeExporter commented 9 years ago
Hi, thanks for using autosub and more thanks for this detailed bug report!

You can expect a bug fix for this soon!

Original comment by romke.va...@gmail.com on 16 Feb 2012 at 9:45

GoogleCodeExporter commented 9 years ago

Original comment by romke.va...@gmail.com on 18 Feb 2012 at 2:38

GoogleCodeExporter commented 9 years ago

Original comment by romke.va...@gmail.com on 19 Feb 2012 at 2:24

GoogleCodeExporter commented 9 years ago
Issue 42 has been merged into this issue.

Original comment by romke.va...@gmail.com on 19 Feb 2012 at 2:59