search

chenqingyu / auto-sub

Automatically exported from code.google.com/p/auto-sub
0 stars 0 forks source link

Incorrect linefeed make some clients fail on playing subtitle files #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Because AutoSub does not write the subtitle file in binary mode: 
f = open(desination, 'w')

Subtitles are download with extra linefeeds:

1

00:00:02,653 --> 00:00:05,529

Naar rechts.

While it should be:

1
00:00:02,653 --> 00:00:05,529
Naar rechts.

By change one line in the source code this issue is fixed:
line 60 in autosub.downloadSubs: open(destsrt, 'w').write(response.read())
change it into: open(destsrt, 'wb').write(response.read())

Original issue reported on code.google.com by romke.va...@gmail.com on 19 Mar 2012 at 1:11

GoogleCodeExporter commented 9 years ago 
Fixed in upcoming release
Note: Not yet pushed!

Original comment by romke.va...@gmail.com on 23 Mar 2012 at 12:22