`mappings` does not default correctly even if `default_mappings` is set

chentoast / marks.nvim

A better user experience for viewing and interacting with Vim marks.

MIT License

798 stars 40 forks source link

`mappings` does not default correctly even if `default_mappings` is set #7

Closed andrewferrier closed 2 years ago

andrewferrier commented 2 years ago

If I do not include mappings = {} in my require'marks'.setup { block, whether default_mappings is absent, set to true, or false, I get this error:

E5113: Error while calling lua chunk: ...fig/nvim/pack/packager/opt/marks.nvim/lua/marks/init.lua:112: bad argument #1 to 'pairs' (table expec
ted, got nil)

Probably marks.nvim should just default mappings to {} in this case (maybe an error if default_mappings == false).

Thanks for your work on this plugin! Seems great so far.

chentoast commented 2 years ago

Whoops. Should be fixed in master, if you could check that -thanks!

andrewferrier commented 2 years ago

Yep, looks good :) Thanks for the fast response ;)