chentoast / marks.nvim

A better user experience for viewing and interacting with Vim marks.
MIT License
783 stars 40 forks source link

feat: add bookmark toggling (#90) #91

Closed lawrence-laz closed 1 year ago

lawrence-laz commented 1 year ago

This adds <Plug>(Marks-toggle-bookmark[0-9]) and toggle_bookmark[0-9] so that we could create/delete bookmarks with a single key combination (relates to #90) .

I did not add a default mapping for this since I use quite custom keybindings, so not sure what would make sense with defaults. Maybe you have some suggestions? Or it could be left without a default mapping.

chentoast commented 1 year ago

I'll take a closer look tomorrow, but everything seems in place to me. I think it's fine to leave it unmapped - the fact that no one has asked for this feature yet may suggest that people have been mostly happy enough without it

chentoast commented 1 year ago

Thanks for being patient with me. Tried it out locally and everything looks good to me :+1: