search

chentoast / marks.nvim

A better user experience for viewing and interacting with Vim marks.
MIT License
783 stars 40 forks source link

fix: disable display-signs on floating windows #99

Open triarius opened 7 months ago

triarius commented 7 months ago

The filetype exclusions are not the best way to disable the mark signs on certain windows as the filetype is a property of the buffer, while floating is a property of the window. The same filetype could be displayed differently depending on whether its window is floating or not. I think most users are unlikely to want these in floating windows, so I disabled them entirely. I'd be happy to make this configurable, but I think the default should be that they are not shown, as typically the normal editing workflow does not apply to floating windows.

In my case, they appear in LSP hints, which are not intended to hold a cursor. It also makes the content no longer fit in the window.

Fixes: #60

Screenshots for LSP

Before

2023-11-25-17-46-48

After

2023-11-25-17-46-10

Screenshots for Neo Tree

Ignore the line numbers, they are caused by a different plugin.

Before

2023-11-25-17-08-44

After

2023-11-25-17-09-23

ofseed commented 6 months ago

I found this PR just now. I have the same problem and made this https://github.com/chentoast/marks.nvim/pull/101

Charlie-83 commented 5 months ago

I was having the same problem with LazyGit. This commit fixes it for me

chentoast commented 5 months ago

I didn't like the proposal of blanket disabling mark displays on floating windows. I think that using the fix proposed in #101 presents a better and more configurable alternative.