chenwardT / lol_stats2

Website to perform match aggregation and analysis for Riot Games' League of Legends.
2 stars 0 forks source link

Refine algorithm for getting "recent" matches for a summoner #11

Open chenwardT opened 8 years ago

chenwardT commented 8 years ago

Since Riot implemented the "match list" endpoint and removed "match history", a summoner's match IDs are now returned in full. We don't want to then go on to query match IDs that we already have in the DB, nor do we want to get all the matches that are returned but unknown.

get_matches_from_ids currently has a simple algorithm that gets matches from the beginning of time or the end of time, up to a maximum # of matches (recent_first and max_matches params, respectively). This should be reexamined with an eye towards user expectations of behavior.