chenweize1998 / fully-hyperbolic-nn

Code for paper Fully Hyperbolic Neural Networks
74 stars 12 forks source link

Midpoint Definition #6

Closed inboxedshoe closed 1 year ago

inboxedshoe commented 1 year ago

Hey,

Just wanted to ask, the paper defines the mid point as:

$\sqrt{1/k}\frac{\sum{v.x}}{\left|v.x \right|_L}$

but the code in kg/manifolds/lorentz : $\sqrt{k}\frac{\sum{v.x}}{\left|v.x \right|_L}$ where: k=-K

is there any particular reason for this?

inboxedshoe commented 1 year ago

the base assumption was wrong here I believe, I think the code k = -1/K