chenxiaolong / BCR

A Basic Call Recorder for rooted Android devices
GNU General Public License v3.0
1.62k stars 107 forks source link

Immediately No BCR Application with 1.34 on miui 13 #251

Open carstengrimm opened 1 year ago

carstengrimm commented 1 year ago

02-22 21:09:14.125  8185  8185 W ziparchive: Unable to open '/system/priv-app/com.chiller3.bcr/app-debug.apk': No such file or directory
02-22 21:09:14.126  8185  8185 E om.chiller3.bc: Failed to open APK '/system/priv-app/com.chiller3.bcr/app-debug.apk': I/O error

on a quick log in the adb logcat i can see those errors who stand out

chenxiaolong commented 1 year ago

Hmm, I have no idea what would be causing that, especially the I/O error.

Do you happen to have Magisk's denylist enabled for any system apps?

carstengrimm commented 1 year ago

I have adjusted the issue, as it makes not that much sense to have issues on the debug versions. i have now installed the 1.34 build, and there's no bcr application found in the launcher.

inside

data/adb/modules/com.chiller3.bcr/system/priv-app/com.chiller3.bcr/

i can see there's an app-release.apk

(let me also check denylist)

carstengrimm commented 1 year ago

image

i'm using delta magisk, which features magisk hide/SuList as with 1.34, the app is not recognized in launcher, i can not select is as SuList exception (make it access SU)

image

chenxiaolong commented 1 year ago

Can you post the output of:

ls -lR /data/adb/modules/com.chiller3.bcr /system/priv-app/com.chiller3.bcr /system/etc/permissions/privapp-permissions-com.chiller3.bcr.xml

I took a quick look at Magisk Delta and it seems that its mount logic is very different from the normal Magisk.

Also, does BCR work if you turn off SuList completely? I wonder if BCR's apk is getting hidden from Android itself.

carstengrimm commented 1 year ago

i have manually installed the APK from Zip, as well as make add it to SUList, give permissions and undo freeze-functions.

seems like it doesn't trigger root

1|veux:/ $ su
chiller3.bcr /system/priv-app/com.chiller3.bcr /system/etc/permissions/privapp-permissions-com.chiller3.bcr.xml       <

-rw-r--r-- 1 root root  292 2023-02-22 21:19 /system/etc/permissions/privapp-permissions-com.chiller3.bcr.xml

/data/adb/modules/com.chiller3.bcr:
total 43
-rw-r--r-- 1 root root 35149 2023-02-22 21:19 LICENSE
-rw-r--r-- 1 root root   207 2023-02-22 21:19 module.prop
drwxr-xr-x 5 root root  3452 2023-02-22 21:19 system

/data/adb/modules/com.chiller3.bcr/system:
total 9
drwxr-xr-x 2 root root 3452 2023-02-22 21:19 addon.d
drwxr-xr-x 3 root root 3452 2023-02-22 21:19 etc
drwxr-xr-x 3 root root 3452 2023-02-22 21:19 priv-app

/data/adb/modules/com.chiller3.bcr/system/addon.d:
total 4
-rw-r--r-- 1 root root 277 2023-02-22 21:19 51-com.chiller3.bcr.sh

/data/adb/modules/com.chiller3.bcr/system/etc:
total 3
drwxr-xr-x 2 root root 3452 2023-02-22 21:19 permissions

/data/adb/modules/com.chiller3.bcr/system/etc/permissions:
total 4
-rw-r--r-- 1 root root 292 2023-02-22 21:19 privapp-permissions-com.chiller3.bcr.xml

/data/adb/modules/com.chiller3.bcr/system/priv-app:
total 3
drwxr-xr-x 2 root root 3452 2023-02-22 21:19 com.chiller3.bcr

/data/adb/modules/com.chiller3.bcr/system/priv-app/com.chiller3.bcr:
total 3652
-rw-r--r-- 1 root root 3735008 2023-02-22 21:19 app-release.apk

/system/priv-app/com.chiller3.bcr:
total 3652
-rw-r--r-- 1 root root 3735008 2023-02-22 21:19 app-release.apk
veux:/ #
carstengrimm commented 1 year ago

that's the install log for 1.34

- Copying zip to temp directory
- Installing BCR-1.34-release.zip
- Current boot slot: _a
- Device is system-as-root
Archive:  /data/user/0/c.n.izitemxlhxzmo/cache/flash/install.zip
  inflating: module.prop
*****************
 BCR 
 by chenxiaolong 
*****************
Archive:  /data/user/0/c.n.izitemxlhxzmo/cache/flash/install.zip
  inflating: customize.sh
*******************
 Powered by Magisk 
*******************
- Extracting module files
Archive:  /data/user/0/c.n.izitemxlhxzmo/cache/flash/install.zip
  inflating: module.prop
  inflating: customize.sh
  inflating: LICENSE
  inflating: README.md
   creating: overlay/
   creating: overlay/addon.d/
  inflating: overlay/addon.d/51-com.chiller3.bcr.sh
   creating: overlay/etc/
   creating: overlay/etc/permissions/
  inflating: overlay/etc/permissions/privapp-permissions-com.chiller3.bcr.xml
   creating: overlay/priv-app/
   creating: overlay/priv-app/com.chiller3.bcr/
  inflating: overlay/priv-app/com.chiller3.bcr/app-release.apk
Using /system as the installation target
'/data/adb/modules_update/com.chiller3.bcr/overlay' -> '/data/adb/modules_update/com.chiller3.bcr/system'
- Done

tried from scratch, can't find bcr app after magisk install.

chenxiaolong commented 1 year ago

seems like it doesn't trigger root

That's expected. BCR only uses Magisk for installation. Once installed, it never uses root (it only needs system app permissions).

/system/priv-app/com.chiller3.bcr:
total 3652
-rw-r--r-- 1 root root 3735008 2023-02-22 21:19 app-release.apk

Based on this, I'm not sure what else would cause the issue. Even if all of the other files were missing, the app should still at least show up.

carstengrimm commented 1 year ago

It may be the case that the app listed there is the one I have manually installed extracting from the zip file ... Or that cannot be the case? E.g. seeing the path.

And with the manual installation maybe not having sufficient rights to record,... After setting all options within the app and making sure battery saver isn't on, I made a few test calls. No recordings have been saved and there was no notification either.

I undid everything before and after flashing 1.34 the application cannot be found in the launcher.

chenxiaolong commented 1 year ago

It may be the case that the app listed there is the one I have manually installed extracting from the zip file ... Or that cannot be the case? E.g. seeing the path.

That can't be the case. Manually installed apps end up in /data/app/.

And with the manual installation maybe not having sufficient rights to record,...

Yep, this is the main reason that Magisk is needed for installation. Android only allows system apps to access the call audio.


I don't really have any ideas for what else to try, but if you're willing to upload the full logcat with BCR installed, I can take a look and see if I find anything unusual.

carstengrimm commented 1 year ago

what exactly will you need?

chenxiaolong commented 1 year ago

In the logcat, I'd mainly be looking for anything related to com.chiller3.bcr, magisk, the Android package manager (installd), and selinux (avc: denied).