search

chenxiaolong / BCR

A Basic Call Recorder for rooted Android devices
GNU General Public License v3.0
1.76k stars 113 forks source link

Bump AGP to 8.0.0 #294

Closed PatrykMis closed 1 year ago

PatrykMis commented 1 year ago

I would correct the following deprecation warning, but it's out of my knowledge / I don't understand this:

app/build.gradle.kts:209:52: 'getter for id: Long' is deprecated. Deprecated in Java

chenxiaolong commented 1 year ago

app/build.gradle.kts:209:52: 'getter for id: Long' is deprecated. Deprecated in Java

I've seen this before sometimes and I think it might be a bug in the linter. Thread.getId() isn't deprecated in any version of Java.

PatrykMis commented 1 year ago

@chenxiaolong You've pointed me the right direction searching for solution: https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/lang/Thread.html#getId()

@Deprecated(since="19") public long getId() Deprecated. This method is not final and may be overridden to return a value that is not the thread ID. Use threadId() instead.
chenxiaolong commented 1 year ago

Ah, nice find! I only checked JDK 8 and 17.

I've fixed this in #297 by avoiding using the thread ID altogether.