chenxiaolong / BCR

A Basic Call Recorder for rooted Android devices
GNU General Public License v3.0
1.63k stars 107 forks source link

[REQUEST] for KernelSU support #343

Open Alexios13 opened 1 year ago

Alexios13 commented 1 year ago

Hi! I am aware of the #234, but in my case the module didn't work. I am using android 13 custom rom with kernel 4.14.312. There is a screenshot with the errors during the installation: Screenshot_20230511-140010 If it is possible, I would love to have bcr working with kernelsu. Screenshot_20230511-141236_KernelSU Screenshot_20230511-141231_KernelSU

chenxiaolong commented 1 year ago

I would suggest reporting this on the KernelSU issue tracker. From your first screenshot, the mounting error occurs in KernelSU's code before BCR's install script runs.

Rtizer-9 commented 1 year ago

@chenxiaolong ksu implementation has changed a lot in previous releases so can you please look into it again as many modules are working perfectly except few in ksu.

The reason it's important is that ksu at the moment is doing far better job of hiding root and even managing root permissions. Many apps are straight out refusing to work with magisk being present and bcr is one of the most pressing reasons I can't switch to ksu already.

chenxiaolong commented 1 year ago

@chenxiaolong ksu implementation has changed a lot in previous releases so can you please look into it again as many modules are working perfectly except few in ksu.

I can't personally test KernelSU myself. Is there a specific issue you're running into? Based on KernelSU's documentation (https://kernelsu.org/guide/difference-with-magisk.html), none of the differences between KernelSU and Magisk should affect BCR. BCR's module doesn't use any of the fancy functionality.

Rtizer-9 commented 1 year ago

It's just that last time I installed it, the recording never happened and there were crash logs in the folder. As far as I remember the installation went perfectly well. It would have been great if instead of a module this application worked with only root permissions which you can easily give in ksu.

Next time I'll try installing it I'll tell you what specific error I'm running into.

I didn't know bcr isn't using any magisk specific thing making it completely incompatible with ksu.

chenxiaolong commented 1 year ago

Ah yep, BCR only needs system app permissions, since that's what Android requires to access the call audio. BCR doesn't actually rely on Magisk/KernelSU's root functionality at all--the module is only used to put the .apk in /system/priv-app and the permissions config file in /system/etc/permissions.

symbuzzer commented 1 year ago

I installed BCR via KernelSU without any problem. Also it works flawlessly.

Rtizer-9 commented 1 year ago

@symbuzzer Thanks a lot for letting us know and saving us from more hits and trial just to check. I'll try testing it now.

onlyysaurabh commented 1 year ago

Installing the apk and giving it root access solved the issue for me

akapu1 commented 6 months ago

I having issues with BCR on KernelSU as well. After flashing BCR the won't open unless giving root permission. No App icon on launcher as well. When I activate call recording BCR records call without any audio. I get a lot of error logs. BCR works flawlessly with Magisk. Please look into the issues with KernelSU. @chenxiaolong

Rtizer-9 commented 6 months ago

@akapu1 it works flawlessly with ksu. Try fresh installation once more and make sure shamiko isn't installed as it isn't compatible with bcr yet and you'll keep facing things as you mentioned about no icon and audio.

akapu1 commented 6 months ago

@akapu1 it works flawlessly with ksu. Try fresh installation once more and make sure shamiko isn't installed as it isn't compatible with bcr yet and you'll keep facing things as you mentioned about no icon and audio.

I tried uninstalling and reinstalling several times but never got app icon and proper recording. I don't have shamiko but I have Zygisk Next.

Rtizer-9 commented 6 months ago

@akapu1 I'm on ksu with Zygisk next and have not given root permission ( I thought I've because I always do and have no problem giving it but as dev has mentioned here itself it doesn't need it) and it's working perfectly.

Maybe try updating both the kernel ksu and ksu manager app, but ideally it should work with outdated ksu too.

PS: sometimes rebooting becomes really necessary after flashing the modules to see the effect.

Your other root hiding modules/app might be the cause.

akapu1 commented 6 months ago

@akapu1 I'm on ksu with Zygisk next and have not given root permission ( I thought I've because I always do and have no problem giving it but as dev has mentioned here itself it doesn't need it) and it's working perfectly.

Maybe try updating both the kernel ksu and ksu manager app, but ideally it should work with outdated ksu too.

I have the latest KSU and KSU Manager installed on my Pixel 8 Pro.

akapu1 commented 6 months ago

Screenshot_20240222-162025 Screenshot_20240222-162038 Screenshot_20240222-162128 Screenshot_20240222-162220 Nothing installed. Still app doesn't open. If I give root permission it opens but can't record voice during calls.

Rtizer-9 commented 6 months ago

You seem to be on a14 and it can also be the cause. You can try installing app as user app and give it root permission as one user pointed in the thread.

akapu1 commented 6 months ago

You seem to be on a14 and it can also be the cause. You can try installing app as user app and give it root permission as one user pointed in the thread.

It works fine on a14 with Magisk

akapu1 commented 6 months ago

You seem to be on a14 and it can also be the cause. You can try installing app as user app and give it root permission as one user pointed in the thread.

After installing as user app it opens normally. I gave it root permission but it can't record calls

Rtizer-9 commented 6 months ago

What exactly changed in your environment from your previous state when it was working perfectly.

Is it happening after this a14 rom upgrade or something else?

Most probably a14 must be the reason.

akapu1 commented 6 months ago

What exactly changed in your environment from your previous state when it was working perfectly.

Is it happening after this a14 rom upgrade or something else?

Most probably a14 must be the reason.

Nothing happened really. I was using BCR on Magisk. I uninstalled BCR from magisk, flashed factory boot_init image and rooted using KernelSU. Installed BCR after that and it didn't work.

I again flashed factory boot image and flashed patched boot_init to use magisk. Installed BCR and it was working again.

Not yet again I removed magisk and installed KSU and BCR and BCR not working.

Rtizer-9 commented 6 months ago

If this is the first time you're trying to use ksu with your a14 rom then it's most probably the a14 thing causing the issue.

Until your issue gets resolved by dev you can try flashing custom kernel with upgraded ksu and install updated ksu manager (from their tg group - it's 11524 as of now) as there have been lots of releases to solve a14 specific issues.

akapu1 commented 6 months ago

If this is the first time you're trying to use ksu with your a14 rom then it's most probably the a14 thing causing the issue.

Until your issue gets resolved by dev you can try flashing custom kernel with upgraded ksu and install updated ksu manager (from their tg group - it's 11524 as of now) as there have been lots of releases to solve a14 specific issues.

Everything else is working just fine with KSU on a14. Problem with just BCR, which works flawlessly on Magisk on a14

akapu1 commented 6 months ago

I think I fixed the issue. I removed BCR module, installed BCR apk as user apk. Gave it all the permissions. Installed BCR module and now recording working fine.

CanerKaraca23 commented 6 months ago

I think I fixed the issue. I removed BCR module, installed BCR apk as user apk. Gave it all the permissions. Installed BCR module and now recording working fine.

You have shamiko?

akapu1 commented 6 months ago

No. I just have ZygiskNext

HongYue1 commented 1 month ago

I think I fixed the issue. I removed BCR module, installed BCR apk as user apk. Gave it all the permissions. Installed BCR module and now recording working fine.

This worked for me, thanks!