search

chenxiaolong / BCR

A Basic Call Recorder for rooted Android devices
GNU General Public License v3.0
1.76k stars 113 forks source link

[Discussion] Change in the "Initially Paused" behavior. #344

Closed bagarwa closed 1 year ago

bagarwa commented 1 year ago

Hi. After updating to the latest BCR version, I see the "Initially Paused" option has been replaced with "Auto-record rules". Reading the description there, I want to confirm / clarify a few things.

Can you please help me understand this new Auto-record rules screen?

First two options are greyed out and not tap-able. I'm guessing that's because I didn't grant it contacts permission. (BCR will still work without it, right? I removed "contact name" chip from the file naming template too.)

In this scenario, does "All other calls" means "all calls", period? (i.e. contacts and unknowns.) With "all other calls" toggle turned on, am I correct to assume that all calls will be recorded and the recording will be saved? If I don't want some of those recordings, I have to manually go to the recording save location and delete them?

Alternatively, if I turn off this "all other calls" toggle, all calls will still be recorded during the call but will be deleted when the call ends? If I want to save any recording, I will have an option to click "save recording" option in the BCR menu while the call is ongoing?

Thanks.

chenxiaolong commented 1 year ago

Yep! Everything you described is exactly how the app behaves.

If I don't want some of those recordings, I have to manually go to the recording save location and delete them?

You can mark the recording for deletion (at the end of the call) via the notification too.

In general:

bagarwa commented 1 year ago

Great, thanks.

etihwjd commented 1 year ago

Sorry for reopening an old issue. Are the new rules set to delete by default? I went to review a call yesterday only to find it was discarded at the end of the call. Upon further checking, BCR hadn't recorded the calls for almost a month. I have altered options regarding automatically deleting calls after a month, but I don't recall changing the options to discard automatically at the end of the call.

If this is default behaviour, it may leave a few people out of luck like I found myself.

chenxiaolong commented 1 year ago

@etihwjd Sorry about that. Looks like you ran into a bug in the migration logic from the old "Initially paused" option to the new auto-record rules (applies to upgrades from old BCR versions). I've opened a new issue at #350 to get this fixed.

etihwjd commented 1 year ago

No worries, dude. With the benefit this software brings to me, I'm happy to contribute if it means sorting it out for others. Looks like changing the rules and directory isn't solving the issue though, looks like calls are still failing to record.

I'll have a play and see if I can find a work around to share.

I'm on A14 Beta 2 on a P6P if that's any help.

chenxiaolong commented 1 year ago

Would you mind creating a new issue for the Android 14 issues? I probably won't be installing the Android 14 beta builds on my P7P, but I'd be happy to help troubleshoot.