Initially paused option is migrated to opposite auto-record rules setting on upgrade

[chenxiaolong]

From https://github.com/chenxiaolong/BCR/issues/344#issuecomment-1559493596:

Sorry for reopening an old issue. Are the new rules set to delete by default? I went to review a call yesterday only to find it was discarded at the end of the call. Upon further checking, BCR hadn't recorded the calls for almost a month. I have altered options regarding automatically deleting calls after a month, but I don't recall changing the options to discard automatically at the end of the call.

If this is default behaviour, it may leave a few people out of luck like I found myself.

---

This is a bug in the migration logic from the old "Initially paused" setting to the new auto-record rules:

• If Initially paused was never changed by the user:
  • Auto-record rules are set to record by default
• If Initially paused was ever changed by the user (even just by turning on and then off):
  • "Initially paused" enabled was migrated to auto-record enabled
  • "Initially paused" disabled was migrated to auto-record disabled

This resulted in the opposite value being used if the user ever toggled "Initially paused".

[chenxiaolong]

This bug can only occur once during an upgrade from an old BCR version.

For folks who have already upgraded to the latest BCR, they'll need to manually update the auto-record rules to what they prefer.

The fix for this bug will only apply to future upgrades from versions before 1.42.

[chenxiaolong]

The migration logic for upgrades has been fixed in version 1.44. People who have already upgraded to 1.42 or 1.43 before will have to manually update the auto-record rules to their preferred behavior.