search

chenxiaolong / BCR

A Basic Call Recorder for rooted Android devices
GNU General Public License v3.0
1.49k stars 98 forks source link

Update all dependencies #529

Closed chenxiaolong closed 1 month ago

chenxiaolong commented 2 months ago

AGP 8.4.1 includes r8 8.4.26. r8 8.4.24 and newer include a fix for the bug where MediaCodecEncoder.encode() is miscompiled, causing a byte code verification exception to be thrown when recording a call.

Upstream bug report: https://issuetracker.google.com/issues/334275655

chenxiaolong commented 2 months ago

Thanks @PatrykMis, I'll get those updated.

chenxiaolong commented 2 months ago

I'm going to hold off on merging this for a few more days because Google has identified the root cause of AGP 8.3.2 causing some code to be compiled incorrectly (https://issuetracker.google.com/issues/334275655). I'd rather not introduce the workaround of completely disabling compiler optimizations if we don't need to.

PatrykMis commented 2 months ago

I'm going to hold off on merging this for a few more days because Google has identified the root cause of AGP 8.3.2 causing some code to be compiled incorrectly (https://issuetracker.google.com/issues/334275655). I'd rather not introduce the workaround of completely disabling compiler optimizations if we don't need to.

I've seen, good thorough job! So let's hope they'll release fixed AGP soon.

NBruderman commented 2 months ago

A fix was issued, next update should work again

NBruderman commented 1 month ago

@chenxiaolong AGP 8.4.0 just came out, which should include the relevant fix

chenxiaolong commented 1 month ago

It unfortunately does not. AGP 8.4.0 uses r8 8.4.22 and the fix for the 8.4.x branch was included only in 8.4.24+.

EDIT: This branch now pins the r8 version to 8.4.24. It seems to work fine in my initial tests.