search

chenxiaolong / Unity-for-Arch-Extra

Extra stuff for the Unity-for-Arch project
25 stars 9 forks source link

LightDM-Unity-Greeter Does Not Compile #2

Closed necopinus closed 12 years ago

necopinus commented 12 years ago

LightDM-Unity-Greeter does not compile anymore, instead throwing numerous "The symbol 'Indicator' could not be found." errors. This issue is described more fully at https://bbs.archlinux.org/viewtopic.php?pid=1082818#p1082818, and in subsequent posts. While I am still not sure what's causing the issue, I've come to suspect that it may actually be related to vala-0.16, rather than any packages in the Unity-for-Arch-Extra or Unity-for-Arch repositories.

In any event, I have identified a work-around contained in the following patch, which I've called valaflags.patch:

--- src/Makefile.am.orig    2012-03-13 13:20:12.000000000 -0600
+++ src/Makefile.am 2012-04-08 01:42:33.147393602 -0600
@@ -34,6 +34,10 @@
    -DINDICATORDIR=\""$(INDICATORDIR)"\"

 unity_greeter_VALAFLAGS = \
+   --vapidir . \
+   --pkg config \
+   --pkg fixes \
+   --pkg indicator \
    --pkg posix \
    --pkg gtk+-3.0 \
    --pkg gdk-x11-3.0 \

Note that I may be going a bit overboard here on the --pkg options, but at least config and indicator seem necesary (I added fixes at the same time I identified config, so it may be worth testing to see if this is really needed or not...).

chenxiaolong commented 12 years ago

As far as I know, vala compiles to C code, which is then compiled with gcc. An extra --pkg option is probably equivalent to an #include <...> line in C. If that is the case, the compiling time would only increase by a few milliseconds, but the resulting binary will still be the same :)

Anyway, thanks for the patch! It'll help those who are having the same build issues :D