chenxiaoqino / getusermedia-to-rtmp

186 stars 61 forks source link

config_vcodec function and socket._vcodec value never used #12

Open panpansh opened 5 years ago

panpansh commented 5 years ago

socket.on('config_vcodec',function(m){ console.log("!!!!!"+m); if(typeof m != 'string'){ socket.emit('fatal','input codec setup error.'); return; } if(!/^[0-9a-z]{2,}$/.test(m)){ socket.emit('fatal','input codec contains illegal character?.'); return; }//for safety socket._vcodec=m; });

panpansh commented 5 years ago

var types = [ "audio/ogg", "audio/webm", "audio/webm;codecs=opus", "audio/webm;codecs=vorbis", "audio/webm;codecs=pcm", // "video/mpeg", "video/x-matroska", "video/x-matroska;codecs=avc1", "video/webm", "video/webm;codecs=vp8", "video/webm;codecs=vp8,opus", "video/webm;codecs=vp8,pcm", "video/webm;codecs=vp8.0", "video/webm;codecs=vp8.0,opus", "video/webm;codecs=vp8.0,pcm", "video/webm;codecs=vp9", "video/webm;codecs=vp9,opus", "video/webm;codecs=vp9.0", "video/webm;codecs=vp9.0,opus", "video/webm;codecs=daala", "video/webm;codecs=h264", "video/webm;codecs=h264,opus", ];

for (var i in types) { console.log( "Is " + types[i] + " supported? " + (MediaRecorder.isTypeSupported(types[i]) ? "Yes !" : "Nope :(")); }

const codec = types[x]; mediaRecorder = new MediaRecorder(stream, { mimeType: codec, //audioBitsPerSecond: 32000, // 32 kbps //videoBitsPerSecond: // in ms //bitsPerSecond: // in ms });

https://developer.mozilla.org/en-US/docs/Web/API/MediaRecorder/MediaRecorder

chenxiaoqino commented 5 years ago

Doesn't really need it, as webm or mp4 is supported by most major browser today.