clear image cache and add space between images

chenyanming / calibredb.el

Emacs calibre client - An Ebook Management Solution in Emacs.

GNU General Public License v3.0

319 stars 16 forks source link

clear image cache and add space between images #11

Closed dalanicolai closed 4 years ago

dalanicolai commented 4 years ago

Hi,

One more PR with minor, but quite essential, improvements. First, it clears the image cache in between fetching for multiple entries, without clearing the cache no new fetched cover will show, but instead always the first fetched cover. Second, added some space between the images in the covers compare preview buffer. Third, I put the require statements back in the calibre-utils.el file, because they are still needed for autoloading the calibredb-list function Four, a very small syntax improvent (list prefered over ` ,)

chenyanming commented 4 years ago

Merged and add two configuration options in 9cab1bc:

calibredb-fetch-metadata-program
calibredb-fetch-metadata-source-alist

Besides, since ivy may not be installed for some users, and it is a simple selection (Cover selection and source selection). I suggest changing ivy-read to completing-read.

dalanicolai commented 4 years ago

Good suggestion, I forgot about completing-read and I will have a look at it. I am cleaning up the code a little also. Because I immediately sent the PR when I got it working sufficiently well, of course a lot of small things can be improved and cleaned/documented. I will work on it a little more and later send another PR.