search

chenyanming / calibredb.el

Emacs calibre client - An Ebook Management Solution in Emacs.
GNU General Public License v3.0
323 stars 17 forks source link

calibredb-add only works if ivy-mode enabled, when ivy-mode is available #50

Closed johanwiden closed 3 years ago

johanwiden commented 3 years ago

I am using calibredb master branch. I am normally using helm for completion. However, I have ivy installed, but ivy-mode not enabled. Then nothing happens when I press 'a' in calibredb-search buffer.

If I enable ivy-mode, and have counsel installed, then I can add documents. Looking at calibredb-add, I believe that an else branch is needed for (if ivy-mode ) that does the same as the 't' case in the (cond ((boundp 'ivy-mode)

Alternatively, only do the cond case if both (boundp 'ivy-mode) and ivy-mode are true.

johanwiden commented 3 years ago

I see, this is already fixed in the develop branch.