chenyanming / nov-xwidget

The best epub reader in Emacs
86 stars 10 forks source link

Invalid function: evil-define-key #8

Closed alan-w-255 closed 1 year ago

alan-w-255 commented 2 years ago

error throw while installing package. I think evil-define-key is macro cause this error.

stottm commented 1 year ago

Confirmed: Seeing this error when opening ePub which fails to render.

generated  Nov 26, 2022 20:25:20
system     MacOS 13.1 Darwin 22.2.0 arm64
emacs      28.2 ~/.config/emacs-configs/doom-emacs/
doom       3.0.0-pre PROFILE=_@0 grafted, HEAD -> master, origin/master,
       origin/HEAD 9d4d5b75 2022-10-31 16:18:16 +0100 ~/.config/doom/
shell      /opt/homebrew/bin/fish
features   ACL DBUS GMP GNUTLS JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY
       KQUEUE PDUMPER THREADS TOOLKIT_SCROLL_BARS XIM XWIDGETS ZLIB
traits     batch server-running envvar-file custom-file
modules    :config use-package :completion (company +childframe) (vertico
       +icons) :ui doom doom-dashboard doom-quit (emoji +unicode) hl-todo
       hydra indent-guides (ligatures +extras) modeline nav-flash ophints
       (popup +all +defaults) treemacs vc-gutter vi-tilde-fringe
       (window-select +numbers) zen :editor (evil +everywhere)
       file-templates fold format multiple-cursors rotate-text snippets
       :emacs (dired +icons +ranger) electric (ibuffer +icons) undo vc :term
       eshell vterm :checkers syntax (spell +flyspell) :tools (eval
       +overlay) (lookup +dictionary +docsets) lsp (magit +forge) make pdf
       rgb upload :os macos tty :lang data emacs-lisp json javascript latex
       lua markdown (org +dragndrop +journal +pretty +publish +noter +pandoc
       +roam2) (python +lsp +pyright) (ruby +rails) rust (scheme +guile) sh
       swift web yaml :app calendar (rss +org) :config (default +bindings
       +smartparens)
packages   (straight :pin 3eca39d) (calibredb :pin
       2f2cfc38f2d1c705134b692127c3008ac1382482) (nov :pin
       cb5f45cbcfbcf263cdeb2d263eb15edefc8b07cb) (nov-xwidget :recipe (:host
       github :repo chenyanming/nov-xwidget))
citizen428 commented 1 year ago

@stottm Since you're also using Doom Emacs, I fixed this by updating ~/.config/emacs/.local/straight/repos/nov-xwidget/nov-xwidget.el (may be in a different location for you, depending on how you installed). I added

(require 'evil-core)

at the top where the other require forms are and recompiled the buffer with M-x emacs-lisp-native-compile-and-load.