chenyanming / paw

Emacs Annotation and Language Learning tool.
67 stars 3 forks source link

Mention that svg-lib is required. paw-pbm-enable should probably be set to nil #4

Closed johanwiden closed 2 weeks ago

johanwiden commented 2 months ago

The README should mention that svg-lib is required. Currently paw-svg.el does not call svg-lib, because paw-svg-enable is nil, but there are still references in the code to svg-lib functions. (I tried setting paw-svg-enable to t, but that did not change the output of paw-note.el)

Currently paw-pbm-enable is set to t. But paw then refers to files that have to be installed in a subdirectory of "doom-private-dir", so it is probably best if the public version of paw has paw-pbm-enable set to nil.

I put the following in my Doom Emacs config: (after! paw (setq paw-pbm-enable nil))

chenyanming commented 2 months ago

Problem fixed.

johanwiden commented 2 months ago

Yes, I can now use svg-lib! I had no luck with setting paw-pbm-enable to t: I still get empty square buttons, even though the path to the image directory is as expected.

chenyanming commented 2 months ago

Did you download the images? (package! paw :recipe (:host github :repo "chenyanming/paw" :files ("*")))

johanwiden commented 2 months ago

Yes, the images are downloaded. And if I browse the image directory in dired, I can view the images.

johanwiden commented 2 months ago

Now paw-pbm-enable works for me! I do not know why it did not before. But in between I updated the package recipe to include :files ("*"), and synced doom emacs again. I also get a highlighted button when I click on the button.

johanwiden commented 2 weeks ago

No longer a problem.